Skip to content

build: git context query format support#809

Merged
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:git-query-url
Mar 9, 2026
Merged

build: git context query format support#809
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:git-query-url

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 14, 2025

Comment on lines +63 to +67
if (await this.buildx.versionSatisfies('>=0.29.0')) {
format = 'query';
} else {
format = 'fragment';
}
Copy link
Member Author

@crazy-max crazy-max Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults to query format since Buildx 0.29.0 related to docker/buildx#3415

There will be a follow-up on build-push-action and bake-action to set BUILDX_SEND_GIT_QUERY_AS_INPUT accordingly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still depends on the dockerfile version as well, so not sure if we can change default before BUILDX_SEND_GIT_QUERY_AS_INPUT

Copy link
Member Author

@crazy-max crazy-max Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated so it defaults to fragment unless BUILDX_SEND_GIT_QUERY_AS_INPUT=true and Buildx version is >=0.29.0.

@crazy-max crazy-max requested a review from tonistiigi October 14, 2025 10:45
@crazy-max crazy-max marked this pull request as ready for review October 14, 2025 11:00
@crazy-max crazy-max force-pushed the git-query-url branch 2 times, most recently from f38a018 to caf0627 Compare October 22, 2025 11:39
@crazy-max crazy-max marked this pull request as draft March 6, 2026 09:14
@crazy-max crazy-max force-pushed the git-query-url branch 3 times, most recently from d57f315 to 23934f7 Compare March 8, 2026 19:41
@crazy-max crazy-max marked this pull request as ready for review March 9, 2026 09:28
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max merged commit b732db2 into docker:main Mar 9, 2026
118 checks passed
@crazy-max crazy-max deleted the git-query-url branch March 9, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants