Skip to content

Deal with Docker's minimum API version nonsense #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosifkit merged 1 commit into from
Feb 17, 2026
Merged

Deal with Docker's minimum API version nonsense #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Install Bashbrew
run: |
# not doing "uses: docker-library/bashbrew@xxx" because it'll build which is slow and we don't need more than just bashbrew here
Expand All @@ -29,7 +30,22 @@ jobs:
chmod +x .bin/bashbrew
.bin/bashbrew --version
echo "$PWD/.bin" >> "$GITHUB_PATH"

# deal with Docker's API version nonsense (the whole entire point of API versioning is avoiding breaking changes, so it's rich and ironic for the prior "LTS" version to have breaking changes from this change)
# https://www.docker.com/blog/docker-engine-version-29/
- run: |
sudo mkdir -p /etc/systemd/system/docker.service.d
sudo tee /etc/systemd/system/docker.service.d/minimum-api-version.conf <<-'EOF'
[Service]
Environment=DOCKER_MIN_API_VERSION=1.42
# API version 1.42 is Docker 23.x
EOF
sudo systemctl daemon-reload
sudo systemctl restart docker.service
docker version

- run: .test/test.sh --deploy

- uses: actions/upload-artifact@v4
with:
name: coverage
Expand All @@ -38,7 +54,10 @@ jobs:
.test/.coverage/GOCOVERDIR/
include-hidden-files: true
if-no-files-found: error

- name: gofmt
run: find -name '*.go' -type f -exec ./.go-env.sh gofmt -l -s -w '{}' +

- run: git diff --exit-code

# TODO download latest coverage artifacts from HEAD / PR target to emulate Codecov but without another flaky third-party service that's begging for write-access to all our repositories via a GitHub App? 👀
2 changes: 1 addition & 1 deletion .test/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ if [ -n "$doDeploy" ]; then
docker rm -vf meta-scripts-test-registry &> /dev/null || :
trap 'docker rm -vf meta-scripts-test-registry &> /dev/null || :' EXIT
docker run --detach --name meta-scripts-test-registry --publish 5000 registry:2
registryPort="$(DOCKER_API_VERSION=1.41 docker container inspect --format '{{ index .NetworkSettings.Ports "5000/tcp" 0 "HostPort" }}' meta-scripts-test-registry)"
registryPort="$(DOCKER_API_VERSION=1.42 docker container inspect --format '{{ index .NetworkSettings.Ports "5000/tcp" 0 "HostPort" }}' meta-scripts-test-registry)"

# apparently Tianon's local system is too good and the registry spins up fast enough, but this needs a small "wait for the registry to be ready" loop for systems like GHA (adding "--cpus 0.01" to the above "docker run" seems to replicate the race reasonably well)
tries=10
Expand Down