-
Notifications
You must be signed in to change notification settings - Fork 0
Fix PAN/OND spec ID parsing bug and add weather utilities, convenience APIs, and improved docs #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iantsednv
wants to merge
18
commits into
main
Choose a base branch
from
bugfix/filename_parsing_better_docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e9f1389
Use Path.stem for PAN/OND spec IDs, export PVSystem enums, improve do…
iantsednv 248132d
Fix PAN/OND spec ID parsing, add weather conversion utils and conveni…
iantsednv f861ced
Update documentation
iantsednv 30eba02
Code linting
iantsednv 23471c0
Update readme
iantsednv 768143f
update readme
iantsednv 435ed6f
update readme
iantsednv b86b5ed
update readme
iantsednv 0230d32
Validate PAN/OND file setters: reject empty/duplicate inputs
iantsednv f88983a
Remove silent fallback when project_year is wrong
iantsednv 27d5f44
Rename function and guard it to tsvs only
iantsednv 3e71b70
Use isoformat to parse timestamps
iantsednv c9673dd
Refactor pandas warning
iantsednv f8d5333
Replace single-year TSV check with sequential-year check to support m…
iantsednv 7acbd69
Update docstrings re units
iantsednv 5fddd42
Use protected_namespaces to silence warnings
iantsednv 8e303ac
Move dev/test/docs to dependency-groups, fold pandas into all, drop w…
iantsednv 0ef7772
Update CICD workflows
iantsednv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
weatherwill not age well. It's already awkward with how the response parsing also optionally uses pandas. One "kick the can down the road" solution is putting it into analldependency while also moving the dev/test/docs dependencies into dependency groups