Fix bumpy add: distinguish skip vs none, respect existing bump files#69
Merged
Conversation
… existing bump files - Add 'skip' level to distinguish "not included" from explicit "none" in bump files - Load existing branch bump files so already-covered packages default to skip - Fix keypress listener cleanup to prevent ghost handlers on subsequent prompts - Fix emitKeypressEvents ordering - Only offer cascade options for actual version bumps, not 'none'
|
The changes in this PR will be included in the next version bump.
|
Cascades are an advanced feature better authored directly in bump files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skiplevel to the bump select prompt to distinguish between "not included in bump file" and explicitly marking a package asnoneskipinstead ofpatchwhen re-runningbumpy addemitKeypressEventsordering to prevent rendering bugs between prompt stepsTest plan
bumpy addinteractively, verify skip/none/patch/minor/major levels work correctlybumpy addagain, verify already-covered packages default to skip