refactor(layouts): dedupe *Pinned overrides via shared_symbols#179
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors pinned layout swap behavior so shared/pinned window detachment is handled by the base Layout:detach_files_for_swap implementation instead of duplicated per pinned layout.
Changes:
- Centralizes shared-symbol detach logic in
lua/diffview/scene/layout.lua. - Removes duplicated
detach_files_for_swapoverrides from pinned Diff1/Diff2 layouts. - Reuses the horizontal pinned Diff2
should_nullimplementation for the vertical pinned variant.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
lua/diffview/scene/layout.lua |
Implements shared-symbol-aware swap detachment generically. |
lua/diffview/scene/layouts/diff_1_pinned.lua |
Removes now-redundant pinned detach override. |
lua/diffview/scene/layouts/diff_1_inline_pinned.lua |
Relies on base shared-symbol detach behavior and updates comments. |
lua/diffview/scene/layouts/diff_2_hor_pinned.lua |
Removes duplicated detach override and updates documentation. |
lua/diffview/scene/layouts/diff_2_ver_pinned.lua |
Aliases shared should_null logic from horizontal pinned layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.