fix(inline): guard async render against teardown and swap races#176
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the diff1_inline layout’s async inline-render pipeline against races caused by entry swaps (use_entry) and teardown (teardown_render/destroy). It introduces a monotonic “render generation” token that invalidates in-flight async work, preventing stale callbacks from overwriting caches or rendering extmarks onto buffers after the layout no longer owns them.
Changes:
- Add
_render_generationtokening plus_is_active_render()guards around async yield points increate,use_entry,_prerender, and_render_inline. - Bump generation on lifecycle transitions (
create,use_entry,teardown_render) so stale async resumes bail out safely. - Add functional tests covering mid-flight generation changes, destroy/teardown during awaits, and cached-instance reuse after destroy.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/scene/layouts/diff_1_inline.lua | Introduces generation-based invalidation to prevent stale async renders from mutating state or leaking extmarks after swaps/teardown. |
| lua/diffview/tests/functional/layouts_spec.lua | Adds regression tests exercising swap/teardown/destroy race scenarios and cached layout reuse. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c3c5e30 to
ea7998a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.