Skip to content

chore: skpkg with no manual edit#93

Merged
sbillinge merged 3 commits intodiffpy:mainfrom
stevenhua0320:skpkg-update
Apr 5, 2026
Merged

chore: skpkg with no manual edit#93
sbillinge merged 3 commits intodiffpy:mainfrom
stevenhua0320:skpkg-update

Conversation

@stevenhua0320
Copy link
Copy Markdown
Contributor

@sbillinge ready to review. I have rescikit-packaged it. I maintained all the license info as before. Moreover, I cleaned the duplicated workflow and edit the README.rst badge link to make it consistent with the workflow. I have also tested locally and the documentation still renders correctly.
Screenshot 2026-04-04 at 3 30 53 PM
Screenshot 2026-04-04 at 3 31 06 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.78%. Comparing base (459f899) to head (609db53).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           4        4           
  Lines         177      177           
=======================================
  Hits          166      166           
  Misses         11       11           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please see comments. Also make sure the duplicate code of conduct file is deleted and any duplicate workflows like matrix on merge to main

@@ -16,6 +16,6 @@ jobs:
with:
project: diffpy.fourigui
c_extension: false
headless: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay as true

]

autodoc_mock_imports = ["h5py", "tkinter", "matplotlib"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if these are still needed. Good if they are not needed but presumably they were added before for done reason

@@ -21,8 +21,7 @@ To get started, please visit the :ref:`Getting started <getting-started>` page.
Authors
=======

``diffpy.fourigui`` is developed by Billinge Group
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave all these statements as they were before.

##############################################################################
#
# (c) 2022-2025 The Trustees of Columbia University in the City of New York.
# (c) 2026 The Trustees of Columbia University in the City of New York.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use your new way of doing the copyright

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e., 2026 - present, diffpy.fourigui contributors and change it everywhere.

Please could you check that scikit package does it this way and make and issue over there if not? Thanks.

@sbillinge sbillinge merged commit b6cd401 into diffpy:main Apr 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants