Skip to content

Update alert model for WATCHING, protocol, and command-exit alerts#67

Merged
nedtwigg merged 8 commits into
mainfrom
codex/replace-bellslashicon
May 15, 2026
Merged

Update alert model for WATCHING, protocol, and command-exit alerts#67
nedtwigg merged 8 commits into
mainfrom
codex/replace-bellslashicon

Conversation

@nedtwigg
Copy link
Copy Markdown
Member

Summary

  • Reworked the alert spec around three independent alert sources: WATCHING, terminal protocol notifications, and command-exit alerts.
  • Renamed ALERT_DISABLED to WATCHING_DISABLED and propagated the terminology through the UI, stories, docs, and tests.
  • Added command-exit alert tracking from semantic shell events, including armed/ringing transitions and precedence rules when protocol alerts arrive in the same batch.
  • Kept the bell icon unfilled when WATCHING is disabled, since BEL and protocol alerts now share the same alert surface.

Testing

  • Added and updated unit tests for alert state transitions, command-exit behavior, and registry/UI state handling.
  • Updated website tutorial detector tests and snapshots to match the renamed WATCHING model.
  • Ran the lib, website, and standalone test suites plus production builds during validation.

nedtwigg and others added 8 commits May 13, 2026 15:37
Removes dead fields from CommandExitWatch (id, rawCommandLine,
attentionLostAt — all write-only), flattens awkward ternaries,
consolidates the four call sites that always cleared both ring
tracks into a clearAllRingsIfActive helper, and extracts a
toPersistedAlert helper to deduplicate the AlertState→Persisted
literal in session-state.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 15, 2026

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 91ac19c
Status: ✅  Deploy successful!
Preview URL: https://3c178cd1.mouseterm.pages.dev
Branch Preview URL: https://codex-replace-bellslashicon.mouseterm.pages.dev

View logs

@nedtwigg nedtwigg marked this pull request as ready for review May 15, 2026 23:29
@nedtwigg nedtwigg merged commit 271da29 into main May 15, 2026
6 checks passed
@nedtwigg nedtwigg deleted the codex/replace-bellslashicon branch May 15, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant