Conversation
3 tasks
Agent-Logs-Url: https://github.com/dgenio/agent-kernel/sessions/5fb5ea48-a67d-46b5-b468-dce096bf5c0e Co-authored-by: dgenio <12731907+dgenio@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add weaver-spec v0.1.0 compatibility declaration and CI job
feat: declare weaver-spec v0.1.0 compatibility + add conformance CI stub
Apr 11, 2026
There was a problem hiding this comment.
Pull request overview
This PR makes agent-kernel’s alignment with weaver-spec v0.1.0 explicit in documentation and adds a CI job scaffold intended to run the upstream conformance suite once it becomes available.
Changes:
- Documented weaver-spec v0.1.0 compatibility in
README.mdwith an invariant-to-implementation mapping (I-01/I-02/I-06). - Added a new
conformanceGitHub Actions job (currently a stub) gated on the existing test job. - Added a changelog entry describing the compatibility declaration and CI stub.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| README.md | Adds a weaver-spec compatibility section and invariant mapping table. |
| .github/workflows/ci.yml | Introduces a conformance job scaffold intended to run the future weaver-spec suite. |
| CHANGELOG.md | Records the README compatibility declaration and the new CI stub job. |
- README I-01: correct claim that raw output is 'never returned'; raw mode exists but is restricted to admin principals only - README I-06: fix revoke_token() → revoke(token_id) and revoke_all() → revoke_all(principal_id) to match actual API - ci.yml: rename job conformance → conformance_stub and display name to make stub status unambiguous in PR check summaries - ci.yml: add comment clarifying weaver-contracts (pip) vs weaver_contracts (Python module) naming difference Addresses copilot-pull-request-reviewer comments on PR #65.
…state weaver-spec is published (v0.2.0) but weaver_contracts.conformance does not yet exist (dgenio/weaver-spec#4 still open). Update: - Echo messages: spec IS published; runner specifically is not yet available - pip install comment: use git+https install path (not bare package name; not on PyPI) and correct distribution name weaver_contracts (underscore) - Remove now-redundant hyphen/underscore clarifying comment (replaced by the git+https install path which sidesteps the naming ambiguity)
weaver-contracts 0.2.0 is on PyPI. Replace git+https install path with bare pip install weaver-contracts. Add inline comment clarifying that PyPI dist name uses a hyphen while the Python module uses an underscore (weaver_contracts).
The internal invariants.md and AGENTS.md had I-02 mapped to budget enforcement (size/depth/field count). The weaver-spec defines I-02 as 'Every Execution Is Authorized and Auditable'. Fix all affected files to use the correct weaver-spec definition: - AGENTS.md: I-02 → authorization + auditability; add note that budget enforcement is an agent-kernel implementation constraint (not a separate weaver-spec invariant number) - docs/agent-context/invariants.md: same correction; add blockquote clarifying budget enforcement's relationship to I-01 - README.md I-02 'How satisfied' cell: replace claim that PolicyEngine evaluates every invocation (incorrect — it runs at grant time only) with accurate two-phase description: PolicyEngine at grant time, verify() at invoke(), TraceStore always - ci.yml: drop version numbers from stub comment to avoid v0.1.0/v0.2.0 mismatch (whoever activates the stub will pin the right version) - CHANGELOG: fix job name reference conformance → conformance_stub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent-kernel already satisfies weaver-spec invariants I-01/I-02/I-06 but had no formal declaration or automated validation. This PR makes the alignment explicit and hooks CI to run the conformance suite once it ships.
Changes
README.mdFirewallalways transformsRawResult → FramePolicyEngine+HMACTokenProvider+TraceStoreon every invocationprincipal_id + capability_id + constraints+ TTL + revocation.github/workflows/ci.ymlconformancejob (gated ontest) with a stub step and inline comment showing the exact replacement oncedgenio/weaver-spec#4ships:CHANGELOG.md[Unreleased]entry for the compatibility declaration and conformance stub.