fix(infra): use trailing slash in CODEOWNERS for ic-interface-spec#256
Open
marc0olo wants to merge 1 commit into
Open
fix(infra): use trailing slash in CODEOWNERS for ic-interface-spec#256marc0olo wants to merge 1 commit into
marc0olo wants to merge 1 commit into
Conversation
`/*` only matches direct children; a trailing slash matches all contents recursively, keeping subdirectories under the required reviewer rules.
|
🤖 Here's your preview: https://soxyi-6iaaa-aaaam-ai2ra-cai.icp0.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/references/ic-interface-spec/*withdocs/references/ic-interface-spec/in CODEOWNERS*does not cross directory separators in gitignore-style patterns, so subdirectories would have fallen through to the catch-all* @dfinity/dxrule, losing the@dfinity/interface-specand@dfinity/core-protocolrequirementsdocs/guides/security/)Sync recommendation
hand-written