fix: update SparseEncodingEncoderTest for #232 MaskedArray wrapping#241
Merged
Conversation
decodeVarBin now returns MaskedArray when fill is null (#232); the two decode_utf8_* encoder tests cast directly to VarBinArray and broke on CI. Unwrap to inner() and assert validity on the masked rows. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The #232 fix made
decodeVarBinreturn aMaskedArraywhen the fill scalar is null. Two existingSparseEncodingEncoderTest.Decodetests were casting the result directly toVarBinArrayand broke on CI withClassCastException. This PR unwraps to.inner()and adds validity assertions.Test plan
./mvnw test -pl writer -Dtest=SparseEncodingEncoderTest -q🤖 Generated with Claude Code