fix: AlpRd propagates left_parts validity; null float rows no longer decode as 0.0 (#234)#239
Merged
Conversation
…decode as 0.0 (#234) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AlpRdEncodingDecoder(fastlanes.alprd) dropped the validity mask on itsleft_partschild: null floating-point rows decoded as0.0instead of null — silent corruption. This is the same null-loss family as #210 (ALP), #225 (RunEnd), and #226/#232 (Sparse).How
Following the #210 template, after decoding the
left_partschild:MaskedArray, capture its.validity()and unwrap to.inner();new MaskedArray(decoded, validity).An ALP-RD array's validity IS its
left_partschild's validity, matching the RustValidityChildcontract.Tests
New
AlpRdEncodingDecoderTest:left_parts→ null output rows (mask survives, valid rows decode via the dictionary);left_parts→ plainDoubleArray, noMaskedArraywrapper (no regression).All 1192 reader unit tests pass.
Conformance
Flips
bi-euro2016fromgap:234tookin the Raincloud conformance matrix.Closes #234.
🤖 Generated with Claude Code