fix(kubectl): bypass wakeUp ping for active in-cluster devspace executions (#3179)#3190
Open
Mallikarjunadevops wants to merge 3 commits intodevspace-sh:mainfrom
Open
Conversation
Mallikarjunadevops
requested review from
FabianKramm and
LukasGentele
as code owners
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3179.
This Pull Request adds a native short-circuit to the
kubectl.wakeUpverification block.If a developer runs
devspace buildinside a self-hosted Kubernetes runner (e.g. GitHub Actions executing inside a Pod), DevSpace explicitly flagsIsInCluster()as true viarest.InClusterConfig().Since the native namespace is fundamentally alive and active (it is actively running the CI builder Pod), executing an intrusive API ping (
kubectl get pods) to 'wake up' the cluster is logically unnecessary. More importantly, because GitHub Action runners are typically securely scoped without broad RBAC (inCluster: false), this ping routinely threw an unprotectedForbiddencrash effectively locking them out of standard builds.By short-circuiting the ping when
IsInCluster()returns true, DevSpace now flawlessly builds CI Docker pipelines without aggressive RBAC demands.Tested successfully via
go test -v ./pkg/devspace/kubectl/...andgo build ./...locally.