feat(toolbar): switch tool icons to embedded SVGs#155
Merged
devmobasa merged 1 commit intodevmobasa:mainfrom Feb 26, 2026
Merged
feat(toolbar): switch tool icons to embedded SVGs#155devmobasa merged 1 commit intodevmobasa:mainfrom
devmobasa merged 1 commit intodevmobasa:mainfrom
Conversation
Owner
|
The icons and design all over the app is something I am not proud of. These look much better, and I love option to easily replace them outside of the code, as it should be. |
Owner
Yeah, perhaps, I am more of a backend person, I don't have an eye for these things :) If you have any other ideas in regards to UI/UX, or anything else feel free to open PR or an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use Wayscriber quite a bit and really enjoy it. It has become part of my regular workflow.
One thing that always stood out to me though were the toolbar icons. Maybe because I am more a frontend dev than backend. They’re functionally fine, but visually they felt a bit inconsistent compared to the rest of the UI.
The existing Cairo paths clearly took time and care to get right. For consistency and maintainability, though, I think using SVG assets is a cleaner long-term approach.
This PR replaces the procedural Cairo-drawn tool icons with Lucide SVG icons rendered via
resvg, aiming for a cleaner and more consistent look while keeping behavior exactly the same.What I changed
toolbar_icons/tools.rsto use the SVG rendererresvgandtiny-skiaas dependenciesdraw_icon_*function signatures unchanged to avoid refactoring call sitesBefore
After
The icons can obviously be changed anytime (in
assets/icons/)cargo testpasses locallyHappy to adjust anything if this doesn’t align with the project direction. I mainly wanted to improve visual consistency without touching behavior or APIs.