Open
Conversation
7633b6e to
bc2281c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2793 +/- ##
===========================================
- Coverage 83.02% 53.22% -29.81%
===========================================
Files 248 248
Lines 50804 50813 +9
Branches 4479 4479
===========================================
- Hits 42180 27044 -15136
- Misses 7857 22801 +14944
- Partials 767 968 +201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EdCaunt
reviewed
Nov 14, 2025
| # Schedule Clusters over different IterationSpaces if this increases | ||
| # parallelism | ||
| for i in range(1, len(clusters)): | ||
| for i in reversed(range(len(clusters) - 1)): |
Contributor
There was a problem hiding this comment.
What's the advantage of working backward through this rather than forward?
Nitpick: I think having the range start at 1, then just having i in the indices was slightly easier to understand
mloubout
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.