chore (deps) : bump go version to v1.25.8#1611
chore (deps) : bump go version to v1.25.8#1611rohanKanojia wants to merge 1 commit intodevfile:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
📝 WalkthroughWalkthroughThis pull request upgrades the Go toolchain version from 1.25.7 to 1.25.8 across the project's build configurations, CI/CD workflows, Dockerfiles, and the go.mod file. No functional code changes are included. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
ecf2f0e to
434cb7b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
==========================================
+ Coverage 35.48% 36.19% +0.71%
==========================================
Files 168 168
Lines 14484 14534 +50
==========================================
+ Hits 5139 5261 +122
+ Misses 9006 8929 -77
- Partials 339 344 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.ci/oci.Dockerfile (1)
18-24: Consider removing duplicateGO_VERSIONdeclarations.The
GO_VERSIONand related environment variables are declared twice (lines 18-20 and 22-24). The second declaration is redundant. While this doesn't cause issues, it's cleaner to have a single declaration.♻️ Proposed fix to remove duplication
ENV GO_VERSION=1.25.8 ENV GOROOT=/usr/local/go ENV PATH=$GOROOT/bin:$PATH -ENV GO_VERSION=1.25.8 -ENV GOROOT=/usr/local/go -ENV PATH=$GOROOT/bin:$PATH - SHELL ["/bin/bash", "-c"]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.ci/oci.Dockerfile around lines 18 - 24, Remove the duplicate environment variable block by keeping a single declaration of GO_VERSION, GOROOT and PATH and deleting the repeated set; specifically, ensure only one ENV GO_VERSION=1.25.8, one ENV GOROOT=/usr/local/go and one ENV PATH=$GOROOT/bin:$PATH remain (remove the second occurrence) so the Dockerfile contains a single authoritative definition for those variables.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.ci/oci.Dockerfile:
- Around line 18-24: Remove the duplicate environment variable block by keeping
a single declaration of GO_VERSION, GOROOT and PATH and deleting the repeated
set; specifically, ensure only one ENV GO_VERSION=1.25.8, one ENV
GOROOT=/usr/local/go and one ENV PATH=$GOROOT/bin:$PATH remain (remove the
second occurrence) so the Dockerfile contains a single authoritative definition
for those variables.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2bf1ae97-7154-4301-bc81-3979876f72c8
📒 Files selected for processing (7)
.ci/oci.Dockerfile.github/workflows/code-coverage.yml.github/workflows/pr.yml.github/workflows/release.ymlbuild/Dockerfilego.modproject-clone/Dockerfile
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Update Go toolchain to 1.25.8
What issues does this PR fix or reference?
This PR aims to resolve CVE that are fixed by:
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with CheSummary by CodeRabbit