Skip to content

chore (deps) : bump go version to v1.25.8#1611

Open
rohanKanojia wants to merge 1 commit intodevfile:mainfrom
rohankanojia-forks:pr/bump-go-version-1-25-8
Open

chore (deps) : bump go version to v1.25.8#1611
rohanKanojia wants to merge 1 commit intodevfile:mainfrom
rohankanojia-forks:pr/bump-go-version-1-25-8

Conversation

@rohanKanojia
Copy link
Copy Markdown
Member

@rohanKanojia rohanKanojia commented Apr 8, 2026

What does this PR do?

Update Go toolchain to 1.25.8

What issues does this PR fix or reference?

This PR aims to resolve CVE that are fixed by:

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain version from 1.25.7 to 1.25.8 across Docker build configurations and CI/CD workflows.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 8, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

📝 Walkthrough

Walkthrough

This pull request upgrades the Go toolchain version from 1.25.7 to 1.25.8 across the project's build configurations, CI/CD workflows, Dockerfiles, and the go.mod file. No functional code changes are included.

Changes

Cohort / File(s) Summary
CI/CD Workflow Go Version Updates
.github/workflows/code-coverage.yml, .github/workflows/pr.yml, .github/workflows/release.yml
Updated actions/setup-go Go version input from 1.25.7 to 1.25.8 across three workflow files.
Dockerfile Go Toolchain Updates
.ci/oci.Dockerfile, build/Dockerfile, project-clone/Dockerfile
Updated Go base image or environment variable from version 1.25.7 to 1.25.8, including SHA256 digest updates for pinned image references.
Go Module Toolchain Declaration
go.mod
Updated toolchain directive from go1.25.7 to go1.25.8.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Poem

🐰 A hop, skip, and version bump so fine,
From 1.25.7 to 1.25.8 we align,
Across workflows, containers, and mod,
The toolchain grows, oh how quite odd!
One tiny change, yet consistent throughout,
No logic shifted, no worries or doubt. 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating Go version from 1.25.7 to 1.25.8 across all configuration files and workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia force-pushed the pr/bump-go-version-1-25-8 branch from ecf2f0e to 434cb7b Compare April 8, 2026 17:52
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.19%. Comparing base (b3e2af5) to head (434cb7b).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
+ Coverage   35.48%   36.19%   +0.71%     
==========================================
  Files         168      168              
  Lines       14484    14534      +50     
==========================================
+ Hits         5139     5261     +122     
+ Misses       9006     8929      -77     
- Partials      339      344       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rohanKanojia rohanKanojia marked this pull request as ready for review April 8, 2026 19:50
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.ci/oci.Dockerfile (1)

18-24: Consider removing duplicate GO_VERSION declarations.

The GO_VERSION and related environment variables are declared twice (lines 18-20 and 22-24). The second declaration is redundant. While this doesn't cause issues, it's cleaner to have a single declaration.

♻️ Proposed fix to remove duplication
 ENV GO_VERSION=1.25.8
 ENV GOROOT=/usr/local/go
 ENV PATH=$GOROOT/bin:$PATH
 
-ENV GO_VERSION=1.25.8
-ENV GOROOT=/usr/local/go
-ENV PATH=$GOROOT/bin:$PATH
-
 SHELL ["/bin/bash", "-c"]
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.ci/oci.Dockerfile around lines 18 - 24, Remove the duplicate environment
variable block by keeping a single declaration of GO_VERSION, GOROOT and PATH
and deleting the repeated set; specifically, ensure only one ENV
GO_VERSION=1.25.8, one ENV GOROOT=/usr/local/go and one ENV
PATH=$GOROOT/bin:$PATH remain (remove the second occurrence) so the Dockerfile
contains a single authoritative definition for those variables.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.ci/oci.Dockerfile:
- Around line 18-24: Remove the duplicate environment variable block by keeping
a single declaration of GO_VERSION, GOROOT and PATH and deleting the repeated
set; specifically, ensure only one ENV GO_VERSION=1.25.8, one ENV
GOROOT=/usr/local/go and one ENV PATH=$GOROOT/bin:$PATH remain (remove the
second occurrence) so the Dockerfile contains a single authoritative definition
for those variables.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2bf1ae97-7154-4301-bc81-3979876f72c8

📥 Commits

Reviewing files that changed from the base of the PR and between 68ce90d and 434cb7b.

📒 Files selected for processing (7)
  • .ci/oci.Dockerfile
  • .github/workflows/code-coverage.yml
  • .github/workflows/pr.yml
  • .github/workflows/release.yml
  • build/Dockerfile
  • go.mod
  • project-clone/Dockerfile

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, rohanKanojia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants