Add shell and unicode sast pipeline tasks#215
Conversation
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
@thepetk you'll need to rebase these changes and fix conflicts
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
@thepetk Konflux seems to be having running into issues, I'll retry again later.
|
/retest |
|
/test all |
|
@michael-valdron: No presubmit jobs available for devfile/devfile-web@main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
Rebased and fingers crossed :D |
https://issues.redhat.com/browse/KONFLUX-2264 Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
|
@michael-valdron I see this one is now passing. So based on my comment here: devfile/registry#601 (comment) we need to merge this one and then the registry. |
|
/retest |
Signed-off-by: thepetk <thepetk@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Description of Changes
Similar to the changes suggested in the registry, the changes here are applied from the onliner provided here: https://github.com/simonbaird/konflux-pipeline-patcher/blob/main/specific-one-liners.md#sast-unicode-and-shell-check-tasks
Related issue is: https://issues.redhat.com/browse/KONFLUX-2264
Related Issue(s)
Fixes devfile/api#1702 (partially)
Acceptance Criteria
Update the sidebar if there is a new file added or an existing filename is changed
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.