chore: update deployment workflow to support pull requests and configure AWS credentials#146
Open
chore: update deployment workflow to support pull requests and configure AWS credentials#146
Conversation
…ure AWS credentials - Added support for pull request triggers in the deployment workflow for specific paths. - Configured AWS credentials using a role to assume, enhancing security. - Updated the AWS region to 'us-west-2' and removed hardcoded access keys.
hrodmn
reviewed
Apr 24, 2025
Contributor
hrodmn
left a comment
hrodmn
left a comment
There was a problem hiding this comment.
Maybe consider removing integration_tests/** from the workflow trigger paths - otherwise looks great!
hrodmn
approved these changes
Apr 29, 2025
hrodmn
reviewed
Apr 29, 2025
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY_DEPLOY }} | ||
| AWS_ROLE_ARN: ${{ vars.AWS_ROLE_ARN }} | ||
| AWS_DEFAULT_ACCOUNT: ${{ secrets.AWS_ACCOUNT_ID }} | ||
| AWS_DEFAULT_REGION: 'us-west-2' |
Contributor
There was a problem hiding this comment.
We might keep this in us-east-1 or any region but us-west-2 to avoid bumping into resource quotas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than asking users to manually trigger deployments, how do we feel about auto-deploying on PRs?
Merge request description