Skip to content

cling sync testing#2

Closed
devajithvs wants to merge 4 commits intomasterfrom
dev.cling_textinput_testing
Closed

cling sync testing#2
devajithvs wants to merge 4 commits intomasterfrom
dev.cling_textinput_testing

Conversation

@devajithvs
Copy link
Owner

This Pull request:

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

- Update tests as errors/warnings will add a new line in TextInput
- Add `CLING_HISTSIZE` functionality with the newly added LLVM patch.
- Update `cling_history` test to match encoded libedit history
@devajithvs devajithvs force-pushed the dev.cling_textinput_testing branch 4 times, most recently from 51bc794 to fffcd69 Compare November 3, 2025 09:34
@devajithvs devajithvs closed this Nov 3, 2025
@devajithvs devajithvs reopened this Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit fffcd69.

♻️ This comment has been updated with latest results.

@devajithvs devajithvs closed this Nov 3, 2025
@devajithvs devajithvs reopened this Nov 3, 2025
@devajithvs devajithvs force-pushed the dev.cling_textinput_testing branch 3 times, most recently from 0785db2 to b11772f Compare November 3, 2025 10:01
@devajithvs devajithvs force-pushed the dev.cling_textinput_testing branch from b11772f to 9bc2263 Compare November 3, 2025 10:52
@devajithvs devajithvs closed this Nov 3, 2025
devajithvs pushed a commit that referenced this pull request Feb 6, 2026
This makes problems like the one reported in root-project#21066 easier to debug by
the user, because there will be a meaningful error message like this
instead of a crash:
```txt
[#2] FATAL:HistFactory -- ERROR: Inconsistent datasets across channel workspaces.
Workspace for channel "SR_3L_0RC_binary_binary_3L_0RC" does not match the datasets in channel "SR_2L_mva_2L_multiclass_ttll".
  Missing datasets:
    - obsData
All channel workspaces must contain exactly the same datasets.
terminate called after throwing an instance of 'RooStats::HistFactory::hf_exc'
  what():  HistFactory - Exception
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant