BREAKING: privilege separation deprecated

[micheelengronne]

No description provided.

[chris-rock]

I think we also need to remove

ssh-baseline/controls/sshd_spec.rb

Lines 35 to 39 in 0932d5f

	sshd_valid_privseparation = if sshd_custom_user != 'root'
	'no'
	else
	ssh_crypto.valid_privseparation
	end

and

ssh-baseline/libraries/ssh_crypto.rb

Lines 172 to 210 in 3849c52

	def valid_privseparation # rubocop:disable Metrics/CyclomaticComplexity
	# define privilege separation set
	ps53 = 'yes'
	ps59 = 'sandbox'
	ps75 = nil
	ps = ps59
	# debian 7.x and newer has ssh 5.9+
	# ubuntu 12.04 and newer has ssh 5.9+
	case inspec.os[:name]
	when 'debian'
	case inspec.os[:release]
	when /^6\./
	ps = ps53
	when /^10\./
	ps = ps75
	end
	when 'redhat', 'centos', 'oracle'
	case inspec.os[:release]
	# redhat/centos/oracle 6.x has ssh 5.3
	when /^6\./
	ps = ps53
	when /^7\./
	ps = ps59
	when /^8\./
	ps = ps75
	end
	when 'ubuntu'
	case inspec.os[:release]
	when /^18\./
	ps = ps75
	end
	when 'fedora', 'alpine'
	ps = ps75
	end
	ps
	end

[micheelengronne]

We must also warn that it will break compatibility with previous versions.

[chris-rock]

It is not a breaking change since the control stays available. I agree that the version bump for the profile should be major instead of minor

[micheelengronne]

I added BREAKING in the title to introduce a new MAJOR version.