Fix: Skip view fetching when viewNs is not configured#316
Open
Mosh-K wants to merge 1 commit intodelegateas:gh_masterfrom
Open
Fix: Skip view fetching when viewNs is not configured#316Mosh-K wants to merge 1 commit intodelegateas:gh_masterfrom
Mosh-K wants to merge 1 commit intodelegateas:gh_masterfrom
Conversation
Views are only fetched when viewNs is set in gSettings, avoiding the "index out of range" crash during view processing reported in delegateas#266 and delegateas#124. SaveMetadataToFile continues to fetch views unconditionally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Views are only fetched when viewNs is set in gSettings, avoiding the "index out of range" crash during view processing reported in #266 and #124. SaveMetadataToFile continues to fetch views unconditionally.