test: Add regression test for unintended agent execution#11244
Merged
bogdankostic merged 2 commits intomainfrom May 6, 2026
Merged
test: Add regression test for unintended agent execution#11244bogdankostic merged 2 commits intomainfrom
bogdankostic merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Member
|
This should fail with Haystack 2.27, right? |
Contributor
Author
Yes. |
anakin87
approved these changes
May 5, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
I struggled a bit to reproduce it. Sorry, now all good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
pipeline_run_argsinjection #11109Proposed Changes:
This PR adds a regression test for #11109.
The test sets up a pipeline where a
ConditionalRouterroutes to aplanningbranch, leaving theBranchJoinerconnected toAgent.messagesun-triggered. It then runs the pipeline with astreaming_callbackinjected throughpipeline.run(data=...)for theagentcomponent. It asserts that theAgentdoes not run and that the underlying chat generator is never called, i.e. injecting an auxiliary input must not by itself trigger the component.How did you test it?
I ran the test both with the current version of
Agentand with the version wheremessagesis optional (the test fails in this case).Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.