Skip to content

test(lammps): skip spin DPA3 empty-subdomain pt2 case#5478

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bothub:test-skip-spin-dpa3-pt2-empty-subdomain
Open

test(lammps): skip spin DPA3 empty-subdomain pt2 case#5478
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bothub:test-skip-spin-dpa3-pt2-empty-subdomain

Conversation

@njzjz-bot
Copy link
Copy Markdown
Contributor

@njzjz-bot njzjz-bot commented May 30, 2026

Problem

  • The spin DPA3 PT2 MPI empty-subdomain test can fail with a divide-by-zero/SIGFPE when one rank has no real local atoms (nloc_real == 0).
  • This blocks CI while the with-comm AOTI artifact still needs a proper empty-local-atom fast path.

Change

  • Temporarily skip test_pair_deepmd_mpi_dpa3_spin_empty_subdomain.
  • Leave an inline TODO in the skip reason documenting the required follow-up fix.

Notes

  • This is intentionally a narrow unblocker; the test body is kept in place as coverage to re-enable once the fast path lands.
  • Local validation: git diff --check passed. uv run pytest --collect-only -q source/lmp/tests/test_lammps_spin_dpa3_pt2.py is blocked locally by the existing aarch64 uv dependency conflict between pin-jax-cpu (jax==0.10.0) and pin-jax-gpu (jax[cuda12]==0.5.0).

Authored by OpenClaw (model: custom-chat-jinzhezeng-group/gpt-5.5)

Summary by CodeRabbit

  • Tests
    • Disabled a multi-rank MPI test due to a known issue currently under investigation.

Review Change Stack

Skip the spin DPA3 MPI empty-subdomain test while the with-comm AOTI artifact lacks an empty-local-atom fast path. The skipped test keeps a TODO pointing at the nloc_real == 0 divide-by-zero/SIGFPE follow-up.

Authored by OpenClaw (model: custom-chat-jinzhezeng-group/gpt-5.5)
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7ea3a518-596a-453a-abb3-33fc3afa2e44

📥 Commits

Reviewing files that changed from the base of the PR and between e679b8d and 2a15337.

📒 Files selected for processing (1)
  • source/lmp/tests/test_lammps_spin_dpa3_pt2.py

📝 Walkthrough

Walkthrough

A pytest skip marker is added to the test_pair_deepmd_mpi_dpa3_spin_empty_subdomain test in the LAMMPS spin model tests, disabling it with an explicit reason citing a divide-by-zero/SIGFPE failure that occurs when a rank has zero local real atoms during multi-subdomain MPI execution.

Changes

Test Skip Marker

Layer / File(s) Summary
Skip empty-subdomain MPI test with divide-by-zero issue
source/lmp/tests/test_lammps_spin_dpa3_pt2.py
The test_pair_deepmd_mpi_dpa3_spin_empty_subdomain test is marked with @pytest.mark.skip() to suppress a SIGFPE crash occurring when nloc_real == 0 on any MPI rank in multi-subdomain execution. A TODO comment documents the issue for future resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Python, LAMMPS

Suggested reviewers

  • njzjz
  • iProzd
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: skipping a particular test case for spin DPA3 empty-subdomain in LAMMPS PT2.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@njzjz njzjz requested a review from wanghan-iapcm May 30, 2026 07:48
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.25%. Comparing base (e679b8d) to head (2a15337).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5478      +/-   ##
==========================================
- Coverage   82.25%   82.25%   -0.01%     
==========================================
  Files         833      833              
  Lines       89100    89099       -1     
  Branches     4225     4227       +2     
==========================================
- Hits        73290    73289       -1     
+ Misses      14518    14517       -1     
- Partials     1292     1293       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if pr #5485 solves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants