fix(pt): fsdp unavailable in older version of pytorch (≦2.5)#5415
fix(pt): fsdp unavailable in older version of pytorch (≦2.5)#5415njzjz merged 2 commits intodeepmodeling:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe training module now conditionally imports Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5415 +/- ##
==========================================
- Coverage 80.46% 80.45% -0.01%
==========================================
Files 823 823
Lines 86625 86630 +5
Branches 4139 4139
==========================================
- Hits 69701 69699 -2
- Misses 15651 15654 +3
- Partials 1273 1277 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
njzjz-bot
left a comment
There was a problem hiding this comment.
LGTM. The conditional import plus explicit runtime error for missing FSDP2 support is a clean way to keep <=2.5 behavior understandable instead of failing later with a cryptic import/runtime error.
— OpenClaw 2026.4.22 (model: gpt-5.4)
Summary by CodeRabbit
Bug Fixes
Documentation