test(e2e): source VirtualDiskCreation from the custom e2e-br image#2633
Open
Isteb4k wants to merge 2 commits into
Open
test(e2e): source VirtualDiskCreation from the custom e2e-br image#2633Isteb4k wants to merge 2 commits into
Isteb4k wants to merge 2 commits into
Conversation
Point every VirtualDiskCreation data source (HTTP, Upload, registry, VirtualImage, ClusterVirtualImage) at the minimal custom e2e-br image: a Selectel qcow2 for HTTP/Upload and a ttl.sh container-disk for the registry source. Drop the cloud-init provisioning for the test's VM — it only needs the VM as a disk consumer with a live guest agent and never logs in, so no user has to be created. New object symbols (ImageURLCustomBIOS, ImageURLCustomContainer, PrecreatedCVICustomBIOS) are additive; existing constants are left untouched, so other e2e tests keep their behavior. Signed-off-by: Dmitry Rakitin <dmitry.rakitin@flant.com>
The custom e2e-br image is ~35 MiB and grows its root filesystem to the disk on first boot, so the 400Mi disks are oversized. Use a 50Mi vdCreationImageSize for the image-backed VirtualDisks instead. Signed-off-by: Dmitry Rakitin <dmitry.rakitin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
VirtualDiskCreationnow sources every data-source variant from the minimalcustom
e2e-brimage instead of the stock Alpine image:/e2e/custom.qcow2);ttl.sh;v12n-e2e-custom-biosbuilt from the same qcow2.The test's VM provisioning is turned off via
vmbuilder.WithProvisioning(nil),overriding
NewMinimalVM's defaultAlpineCloudInit: the scenario only needsthe VM as a disk consumer with a live guest agent and never logs in over SSH,
so no
clouduser has to be created (the custom image ships no cloud-init).New symbols in
internal/object(ImageURLCustomBIOS,ImageURLCustomContainer,PrecreatedCVICustomBIOS) are additive; existing image constants and CVIs areleft untouched, so all other e2e tests keep their current behavior.
Why do we need it, and what problem does it solve?
e2e-bris a ~35 MiB from-scratch Buildroot image intended to replace the~350 MiB Alpine image used by the e2e suite. Before any wider rollout we want to
exercise it end-to-end through
VirtualDiskCreation— which covers all thedata-source kinds (HTTP, Upload, registry, VI, CVI) — while leaving every other
test on the current Alpine image, so the new image can be validated in isolation.
What is the expected result?
VirtualDiskCreationprovisions VirtualDisks from the HTTP, Upload, registry,VirtualImage and ClusterVirtualImage sources backed by the custom image, and the
consumer VM reaches
Running+AgentReady(no SSH login / user required).Other e2e tests are unaffected.
Checklist
Changelog entries