fix(pvc-artifact): relicense CDI-derived files with recognized header#2629
Open
Isteb4k wants to merge 4 commits into
Open
fix(pvc-artifact): relicense CDI-derived files with recognized header#2629Isteb4k wants to merge 4 commits into
Isteb4k wants to merge 4 commits into
Conversation
The DMT license linter rejects the CDI copyright headers on the code
vendored into pvc-artifact ("license header does not match any known
license"). Replace them with the standard Flant JSC Apache 2.0 header
recognized by the linter and add a note crediting the Containerized Data
Importer (CDI) project as the origin, matching the convention already used
in images/dvcr-artifact.
Signed-off-by: Dmitry Rakitin <dmitry.rakitin@flant.com>
…rror The vm-controller can transiently log "failed to release PVC protection: failed to remove finalizer ...: no new finalizers can be added if the object is being deleted" when the built-in pv-protection controller strips kubernetes.io/pvc-protection from a PVC being deleted concurrently. Add it to logFilter so it does not fail the e2e Virtualization-controller log check, alongside the existing vd-protection/pod-protection entries. Signed-off-by: Dmitry Rakitin <dmitry.rakitin@flant.com>
Isteb4k
force-pushed
the
fix/pvc-artifact-license
branch
from
1a4f6d7 to
8374cdd
Compare
prismagod
previously approved these changes
Jul 9, 2026
The DMT license linter parses .go headers with the // line-comment style before the /* */ block style and treats the first // line whose text begins with "Copyright" as the license, which then fails to match any known template. Putting the CDI attribution in a // comment therefore broke the check. Move the attribution (including the original "Copyright <year> The CDI Authors" notice, preserved per Apache License 2.0 section 4(c)) inside the Apache header block comment, after "limitations under the License.". The block still contains the recognized Flant JSC header as a substring, so the DMT linter passes, while the upstream copyright notice is retained. Apply the same treatment to images/dvcr-artifact/pkg/monitoring/prometheus.go. Signed-off-by: Dmitry Rakitin <dmitry.rakitin@flant.com>
Isteb4k
force-pushed
the
fix/pvc-artifact-license
branch
from
3966d29 to
5a58636
Compare
The referenced upstream CDI file carries no copyright header, so no specific year can be retained from it. Credit "The CDI Authors" without asserting a year that is not present in the source. Signed-off-by: Dmitry Rakitin <dmitry.rakitin@flant.com>
Isteb4k
force-pushed
the
fix/pvc-artifact-license
branch
from
4d0c681 to
464144a
Compare
prismagod
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The 22 CDI-derived Go files under
images/pvc-artifactcarried a bareCopyright <year> The CDI Authors.header that the DMTlicenselinter doesnot recognize. This adds the standard Flant JSC Apache 2.0 header (recognized by
the linter) while retaining the original CDI copyright notice, as required by
Apache License 2.0 §4(c).
The original attribution —
Copyright <year> The CDI Authors— is kept insidethe Apache header block comment, right after
limitations under the License.,together with a note crediting the Containerized Data Importer (CDI) project as
the origin. The same treatment is applied to the CDI-derived
images/dvcr-artifact/pkg/monitoring/prometheus.go.The attribution is placed inside the
/* */block (not as a trailing//comment) on purpose: the DMT license parser inspects
.goheaders with the//line-comment style before the block style and treats the first
//linestarting with
Copyrightas the license, which then fails to match any knowntemplate. Keeping it in the block comment lets the linter still match the
recognized Flant JSC header as a substring while preserving the upstream notice.
Why do we need it, and what problem does it solve?
The DMT
licenselinter rejects the bare CDI headers with "license header doesnot match any known license", which fails the DMT check on every PR touching
pvc-artifact. The Flant JSC header is recognized by the linter, and retainingthe CDI copyright notice keeps the vendored code compliant with Apache 2.0.
What is the expected result?
The DMT
licensecheck passes onimages/pvc-artifactandimages/dvcr-artifact;no file reports "license header does not match any known license", and the
original CDI copyright notice is preserved.
Checklist
Changelog entries