Skip to content

fix(core): prevent empty tsc labels on nodes#2351

Open
diafour wants to merge 1 commit into
mainfrom
fix/core/prevent-empty-tsc-labels-on-nodes
Open

fix(core): prevent empty tsc labels on nodes#2351
diafour wants to merge 1 commit into
mainfrom
fix/core/prevent-empty-tsc-labels-on-nodes

Conversation

@diafour
Copy link
Copy Markdown
Member

@diafour diafour commented May 15, 2026

Description

  • Update kube-api-rewriter to v0.2.1
  • Update 3p-kubevirt to v1.6.2-v12n.31 with updated kube-api-rewriter

See:

Why do we need it, and what problem does it solve?

null value for label in the strategic patch means "delete property", but kube-api-rewriter change those nulls to empty strings, so Nodes was labeled with unneeded empty tsc labels.

What is the expected result?

Before:

Stale labels are keeped on node:

      cpu-timer.node.virtualization.deckhouse.io/tsc-frequency: "4192126000"
      cpu-timer.node.virtualization.deckhouse.io/tsc-scalable: "true"
      kubevirt.internal.virtualization.deckhouse.io/schedulable: "true"
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-3599997000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-3599998000: "true"
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-3599999000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-3600000000: "true"
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4191797000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192043000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192085000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192103000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192104000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192106000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192107000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192115000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192121000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192122000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192123000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192124000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192125000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192126000: "true"
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192128000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192130000: ""
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192259000: ""

After:

Rewrite now keep nulls for strategic patch, no stale labels on nodes:

      cpu-timer.node.virtualization.deckhouse.io/tsc-frequency: "4192126000"
      cpu-timer.node.virtualization.deckhouse.io/tsc-scalable: "true"
      kubevirt.internal.virtualization.deckhouse.io/schedulable: "true"
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-3599998000: "true"
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-3600000000: "true"
      scheduling.node.virtualization.deckhouse.io/tsc-frequency-4192126000: "true"

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: core
type: fix
summary: Prevent empty tsc labels on Nodes.

@diafour diafour added this to the v1.9.0 milestone May 15, 2026
@diafour diafour self-assigned this May 15, 2026
@diafour diafour requested a review from danilrwx May 15, 2026 12:41
Comment thread build/components/versions.yml Outdated
edk2: stable202411
core:
3p-kubevirt: v1.6.2-v12n.30
3p-kubevirt: dvp/update-kube-api-rewriter-fix-empty-label-values
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to change after tagging 3p-kubevirt!

- Update kube-api-rewriter to v0.2.1
- Update 3p-kubevirt to v1.6.2-v12n.31 with updated kube-api-rewriter

See:
- deckhouse/kube-api-rewriter#7
- deckhouse/3p-kubevirt#110

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour diafour force-pushed the fix/core/prevent-empty-tsc-labels-on-nodes branch from ea99b3a to 8330afb Compare May 15, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants