fix: Add a wrapper for php binary on the base docker image. Fix #74#85
Open
PierrePaul wants to merge 1 commit intoddev:mainfrom
Open
fix: Add a wrapper for php binary on the base docker image. Fix #74#85PierrePaul wants to merge 1 commit intoddev:mainfrom
PierrePaul wants to merge 1 commit intoddev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
#74 Add default /usr/local/bin/php executable file
How This PR Solves The Issue
To help with static analysis tools like phpcs, we're adding a wrapper named php that actually calls the php binary inside the ddev container.
Manual Testing Instructions
Using default configuration, you should get an error similar to :
Docker error: failed to connect to the docker APIwhich meansphpis really callingddev.