Fall back to 'SQLite' when /version endpoint is unavailable#53
Open
IceboxDev wants to merge 1 commit intodbeaver:develfrom
Open
Fall back to 'SQLite' when /version endpoint is unavailable#53IceboxDev wants to merge 1 commit intodbeaver:develfrom
IceboxDev wants to merge 1 commit intodbeaver:develfrom
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turso's managed libSQL service does not expose a
/versionendpoint at all:LibSqlDatabaseMetaData.readServerVersionpropagates the resultingIOExceptionasSQLException, sogetDatabaseProductName()throws. Clients that rely on the product name to pick a SQL dialect (JetBrains DataGrip / PyCharm in particular) classify the connection asUNKNOWN, which downstream causes a hang on result-set finalization.Fix: when
/versionis unreachable, fall back to a static"SQLite"product name. libSQL is SQLite-compatible at the SQL level, so this gives clients a sensible dialect to pick. If/versionis reachable (self-hosted product name. libSQL is SQLite-compatible at the SQL level, so this gives clients a sensible dialect to pick. If/versionis reachable (self-hosted sqld), the actual server version is used as before.