Adding port so keyring is not overwritten#1536
Open
bechampion wants to merge 2 commits intodbcli:mainfrom
Open
Adding port so keyring is not overwritten#1536bechampion wants to merge 2 commits intodbcli:mainfrom
bechampion wants to merge 2 commits intodbcli:mainfrom
Conversation
|
Yep, nice. Good catch. |
|
Thinking again, I could recommend And, maybe, or not, a "legacy" idea to try with the old format. |
Contributor
|
@DiegoDAF I think it's ok to not try for backwards compatibility in this case. |
|
yep, it's not necessary to keep the compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keys in keychain are overwritten when same user/host is used (this happens a lot when you proxy over ssh where the host is always localhost and username pretty much is always the same)
Before change
After change
Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).