Skip to content

Add REPL sandbox mode test coverage #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolandwalker merged 1 commit into from
Apr 11, 2026
+20 −0
Merged

Add REPL sandbox mode test coverage #1838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions test/pytests/test_main_modes_repl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,6 +937,26 @@ def run(self, text: str) -> Iterator[SQLResult]:
assert any('reconnection failed' in msg for msg in cli.echo_calls)


def test_one_iteration_enters_sandbox_mode_on_must_change_password_error(monkeypatch: pytest.MonkeyPatch) -> None:
patch_repl_runtime_defaults(monkeypatch)

class FakeSQLExecute:
dbname = 'db'
connection_id = 0

def run(self, text: str) -> Iterator[SQLResult]:
raise pymysql.OperationalError(repl_mode.ER_MUST_CHANGE_PASSWORD, 'must change password')

cli = make_repl_cli(FakeSQLExecute())

repl_mode._one_iteration(cli, repl_mode.ReplState(), 'SELECT 1')

assert cli.sandbox_mode is True
assert any('ERROR 1820' in msg for msg in cli.echo_calls)
assert cli.query_history[-1].query == 'SELECT 1'
assert cli.query_history[-1].successful is False


def test_one_iteration_covers_redirect_destructive_success_refresh_and_logfile(monkeypatch: pytest.MonkeyPatch) -> None:
patch_repl_runtime_defaults(monkeypatch)

Expand Down
Loading