Support Truecolor in prompt_toolkit sessions#1550
Conversation
scottnemes
left a comment
There was a problem hiding this comment.
Think you'd have to being using gradients or similar to be able to notice this, so it's a pretty niche use case from what I can gather anyway.
3478134 to
d5ec82a
Compare
|
Findings
Missing tests / edge cases
If you want, I can propose a minimal refactor to make this testable without integration testing. |
Support truecolor in prompt_toolkit sessions if the environment variable COLORTERM contains "truecolor"; otherwise fall back to 8-bit color depth, the prompt_tookit default.
d5ec82a to
7bdc71b
Compare
|
Findings (ordered by severity)
Missing tests / coverage
I didn’t run tests. If you want, I can draft a minimal test and adjust the detection logic. |
Description
Support Truecolor in prompt_toolkit sessions if the environment variable
$COLORTERMcontains "truecolor"; otherwise fall back to 8-bit color depth, the prompt_tookit default.I must admit that between this and dbcli/cli_helpers#102 I cannot yet see a difference. But there was a request for it, which is reasonable.
It would be great if someone attached some screenshots showing the difference.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).