Skip to content

Allow min and max to have same values#92

Open
devel-pa wants to merge 1 commit intodavidchin:masterfrom
devel-pa:master
Open

Allow min and max to have same values#92
devel-pa wants to merge 1 commit intodavidchin:masterfrom
devel-pa:master

Conversation

@devel-pa
Copy link
Copy Markdown

#55

@MatthieuLemoine
Copy link
Copy Markdown

Will also fix #85

@pdfowler
Copy link
Copy Markdown

Testing it out, I'm having trouble "unsetting" the case where the two sliders are both set to the max range.

Repro:

  1. Setup default config w/ range 0-10 and values {min: 0, max: 10}
  2. Drag and set min to the max value (10)
  3. Try sliding the slider back from the max val
    result Slider doesn't move
    Expected min slider can be moved back

This appears to be caused by the "max" slider catching the click event, and not letting it pass through to the min slider. I think that the following simple logic should fix this:

If `valMax === rangeMax && valMax === valMin` : pass event to minSlider

@jhblacklock
Copy link
Copy Markdown
Contributor

Does this need to be picked up again? I'd be happy to build from this PR. We are looking for the same functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants