Set z-index of last used slider handle#82
Open
jjmax75 wants to merge 3 commits intodavidchin:masterfrom
Open
Conversation
Author
|
I'm not sure why the checks are failing, let me know if you're interested in this feature I'd be happy to work through any problems with my code if you think other users would benefit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using this on a project we're currently building.
If it's something you'd like to integrate into the master branch let e know and I'll do some refactoring to make this feature optional.
Reason behind change -
We've given each handle a 44px square touchzone.
Sometimes the handles' touchzone overlaps on the range slider. We want our users to be able to select the last used handle in that case.
Note -
Also needed to modify eslint rules to allow setting styles when looping through child nodes.