Adding ability to show label on hovering the track#69
Open
oyeanuj wants to merge 2 commits intodavidchin:masterfrom
Open
Adding ability to show label on hovering the track#69oyeanuj wants to merge 2 commits intodavidchin:masterfrom
oyeanuj wants to merge 2 commits intodavidchin:masterfrom
Conversation
- adds the event listener, - calculates position and value - adds node for Label
Owner
|
Hey @oyeanuj, at this point, I'm not 100% sure if I want to have a hover label in this library. To me, it feels very specific to your use case (media player) and your design, if you know what I mean. I think a better approach might be to either:
|
Contributor
Author
|
@davidchin I like the second solution. With #44 merged, I can look into nice patterns to decorate the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @davidchin! Back again!
This is another feature that I found myself wanting - an ability to hover on the track and see the value at that position, if one was to click. I am using this library as a slider for a media player, and it is quite an expected behavior in a media player to be able to view the position at certain point to move accurately.
For the PR, I've followed the conventions that you already have in the library. Most of the functionality is there but the only thing I am struggling with is setting the css for the label appropriately based on the event. I imagine this is something you are more adept than I am, so any help would be much appreciated.
If this looks good, and works, then I'll be happy to add docs, tests, et al.
Thank you!