Constrain multi-slider values to within min/max range.#127
Open
pepopowitz wants to merge 1 commit intodavidchin:masterfrom
Open
Constrain multi-slider values to within min/max range.#127pepopowitz wants to merge 1 commit intodavidchin:masterfrom
pepopowitz wants to merge 1 commit intodavidchin:masterfrom
Conversation
Addresses “range out of scope” issue - davidchin#117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the “range out of scope” issue - #117
The issue was happening on a multi-value slider with a wide range of accepted values, when you click on the "outside" edge of the handle.
For example, if the range slider goes from 1 to 100, and my min is on 1, I could make the min go to -1 by clicking on the left edge of the handle and letting go.
I added two tests - one for the min, one for the max.