Add a unique identifier to Slider (#1)#110
Open
eitanavgil wants to merge 1 commit intodavidchin:masterfrom
eitanavgil:master
Open
Add a unique identifier to Slider (#1)#110eitanavgil wants to merge 1 commit intodavidchin:masterfrom eitanavgil:master
eitanavgil wants to merge 1 commit intodavidchin:masterfrom
eitanavgil:master
Conversation
This came as a need I have to style the 2 sliders label differently. The 2 sliders are identical in structure and classes so it is really hard to access them and style them separately. The change uses the type as an additional class (one slider will have additional class 'max' and one will have additional class 'min' E.G. <span class="input-range__slider-container min" style="position: absolute; left: 25%;"> If you think there is a better way to distinguish them please tell me - I will be happy to apply it. Anything that will let me access the 2 labels separately Thanks for your awesome work :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came as a need I have to style the 2 sliders labels differently. The 2 sliders are identical in structure and classes so it is really hard to access them and style them separately. The change uses the type as an additional class (one slider will have additional class 'max' and one will have additional class 'min' E.G.
If you think there is a better way to distinguish them please tell me - I will be happy to apply it. Anything that will let me access the 2 labels separately
Thanks for your awesome work :)