test: migrate network-crud e2e from infra#236
Draft
ecv wants to merge 1 commit into
Draft
Conversation
Migrate the Network CRUD API-contract test out of datum/infra's live-env Chainsaw suite into NSO's local kind harness, per datum-cloud/infra#3006. This test validates a networking.datumapis.com contract owned by NSO, so it belongs in this repo and runs against the local operator pre-merge. Key changes: - Drop the datumctl auth update-kubeconfig setup step and the clusters/cluster: project blocks that targeted ./test-kubeconfig; the test now runs on spec.cluster: nso-standard like the sibling tests. - Remove spec.skip: true; the live blockers in #2733 don't apply to the local operator. - Keep the Network resource body, the Ready assertion (2m timeout), and the delete step intact.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrates the
network-crudChainsaw test out of thedatum/infralive-env suite into NSO's local kind harness attest/e2e/network-crud/.The test creates a
Network(networking.datumapis.com/v1alpha,ipam.mode: Auto), asserts it reachesReady(2m timeout), then deletes it.Why
Per
datum-cloud/infra#3006, infra is consolidating its live-env Chainsaw suite into a single "construct" group and evacuating single-service API-contract tests to their owning repos, run against the local kind harness pre-merge. This test validates anetworking.datumapis.comcontract owned by NSO, so it belongs here. Related:datum-cloud/infra#3005.Adaptations from the infra source
datumctl auth update-kubeconfigsetup step and theclusters:/cluster: projectblocks pointing at./test-kubeconfig. Now targetsspec.cluster: nso-standard, matching sibling tests (networkbinding/ready-when-context-is-ready).spec.skip: true(the live blockers in infra #2733 do not apply to the local operator).Networkbody, theReadyassertion, timeouts, and the delete step intact.Status
WIP / draft.
chainsaw lintpasses. Not verified against a running kind harness.Known-uncertain
NetworktoReady? The siblingnetworkbindingtest deliberately does NOT assert aNetworkalone isReady— it only reachesReadyafter aNetworkContextis drivenReadyby a plugin (which that test patches by hand). If the local operator never moves a standaloneNetworktoReady, the 2m assertion here will time out. This is the same failure mode that motivatedskip: truein infra (#2733). May need either aNetworkContextReady-patch step (as networkbinding does) or a relaxed assertion.default(as the infra source and the networkbinding sibling do) rather than chainsaw's ephemeral$namespace.