Add location-viewer role and include in networking-viewer#162
Open
scotwells wants to merge 2 commits into
Open
Add location-viewer role and include in networking-viewer#162scotwells wants to merge 2 commits into
scotwells wants to merge 2 commits into
Conversation
The location-admin role existed in isolation — nothing inherited it, so even org owners with full networking access were forbidden from listing locations. Adds a read-only location-viewer role and wires it into networking-viewer so the full viewer/admin hierarchy has location read access. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Location resources are expected to move out of the networking group soon; grant location view access via assignable org roles directly rather than through the networking-viewer inheritance chain. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
networking.datumapis.com-location-viewerrole with list/get/watch on locationsnetworking.datumapis.com-location-viewerto theinheritedRolesofnetworking.datumapis.com-viewerWhy
The
networking.datumapis.com-location-adminrole existed in isolation — it wasn't inherited by the viewer or admin role, so even org owners with full networking access were gettingForbiddenwhen trying to listlocations. This blocked workload creation since the compute webhook lists locations to validate city codes.The fix follows the existing pattern (connector-viewer, gateway-viewer, domain-viewer) by splitting read and write access into separate roles and pulling the viewer into the networking-viewer hierarchy.
🤖 Generated with Claude Code