fix(compute): edge cells start cleanly by defaulting networking integration off (#114)#177
Draft
scotwells wants to merge 1 commit into
Draft
fix(compute): edge cells start cleanly by defaulting networking integration off (#114)#177scotwells wants to merge 1 commit into
scotwells wants to merge 1 commit into
Conversation
…ger crash-loop (#114) Edge cells run without the VPC/network-services-operator control plane and carry no networking.datumapis.com CRDs. With the NetworkingIntegration gate defaulting on, the WorkloadDeployment reconciler registered watches for absent kinds (NetworkBinding, Subnet, SubnetClaim), wedging cache sync and crash-looping the manager. Defaulting the gate off makes the shipped cell artifact come up healthy with no operator flags; deployments running network-services-operator opt in with --feature-gates=NetworkingIntegration=true. This complements #172, which made the quota ResourceClaim watch safe by default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compute-manager deployed to edge cells from the shipped cell overlay crash-loops at startup: it watches networking CRDs (
Subnet,SubnetClaim,NetworkBinding) that exist only on control planes, so its cache never syncs and edge compute goes offline. This PR makes the shipped artifact start cleanly by default — networking integration becomes opt-in (--feature-gates=NetworkingIntegration=true) for deployments running network-services-operator. It also fixes the same latent startup crash in the single-cluster quickstart path.Fixes #114.#172 already fixed the quota-watch half; this completes the issue.A default flip rather than an overlay patch because no deployment relies on the old default — production edge cells already set the gate false via infra's Flux patch, so production behavior is unchanged.
Changes
NetworkingIntegrationfeature-gate default to off, and update the flag help accordingly.Build, vet, and the full test suite are green.
Follow-ups (separate PRs)
Networkwatch in management mode (same bug class).🤖 Generated with Claude Code