RTX 5090 benchmark on coco val2017; readme guidance update#23
Open
AlfredMoore wants to merge 1 commit into
Open
RTX 5090 benchmark on coco val2017; readme guidance update#23AlfredMoore wants to merge 1 commit into
AlfredMoore wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates README documentation to reflect a new GPU benchmark entry and switches the documented ONNX export / TensorRT build instructions to a “dynamic” ONNX artifact.
Changes:
- Added RTX 5090 latency numbers and environment note to the benchmark table.
- Updated ONNX export output filename reference from
sam3_static.onnxtosam3_dynamic.onnx. - Updated the
trtexecexample to build from the dynamic ONNX file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| python python/onnxexport.py | ||
| ``` | ||
| This produces `onnx_weights/sam3_static.onnx` plus external weight shards. | ||
| This produces `onnx_weights/sam3_dynamic.onnx` plus external weight shards. |
| 5) Build a TensorRT engine | ||
| ```bash | ||
| trtexec --onnx=onnx_weights/sam3_static.onnx --saveEngine=sam3_fp16.plan --fp16 --verbose | ||
| trtexec --onnx=onnx_weights/sam3_dynamic.onnx --saveEngine=sam3_fp16.plan --fp16 --verbose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark for
RTX 5090wIntel Ultra 7