Use unpack-dependencies so the 21.x version range resolves#138
Draft
datalogics-saharay wants to merge 2 commits into
Draft
Use unpack-dependencies so the 21.x version range resolves#138datalogics-saharay wants to merge 2 commits into
datalogics-saharay wants to merge 2 commits into
Conversation
The unpack goal can't resolve version ranges (MDEP-650), so [21.0,22.0) broke the build (it requested a literal pdfl-[21.0,22.0)-*.zip). Switch each execution to unpack-dependencies, scoped to com.datalogics.pdfl groupId + artifactId, keeping ${jni.classifier} for platform selection, so Maven resolves the range to the latest 21.x. ocr-data stays on LATEST — it's versioned independently (1.x).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
APDFL 21's native lib (libcom-datalogics-DL210PDFL.so) requires GLIBC_2.32, which the Rocky 8 nodes behind the linux-java-samples label don't provide, so the Run Samples stage failed with UnsatisfiedLinkError. Point the Linux matrix axis at the new rocky9-java-samples label (added to rea and ec2-rocky9-intel in tycho), keeping linux-java-samples on Rocky 8 for the v18 samples. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
develop-21samples build fails on all platforms atmaven-dependency-plugin:unpack (unpack-resources):The poms pin the range
[21.0,22.0)but use theunpackgoal with<artifactItems>, which cannot resolve a version range (still-open MDEP-650) — so Maven requests a literal artifactpdfl-[21.0,22.0)-*.zipand 404s. Same root cause the v18 line hit.Fix
Switch each unpack execution from
unpacktounpack-dependencies, which unpacks Maven-core-resolved dependencies (ranges supported). Each execution is explicitly scoped tocom.datalogics.pdflgroup + artifact (<includeGroupIds>+<includeArtifactIds>), with<includeClassifiers>(incl.${jni.classifier}for platform selection) +<includeTypes>zip. Only the 91pom.xmlfiles change.ocr-datais set toLATEST(3 OCR poms): it's versioned independently on a1.xline, decoupled from the APDFL major, so the[21.0,22.0)range matches nothing for it.🤖 Generated with Claude Code