fix: Pass make_kwargs to make_fetch in tripartite pattern #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using generator-based make (make_fetch, make_compute, make_insert), make_kwargs passed to populate() were not being forwarded to make_fetch. This caused TypeError when using make_kwargs with the tripartite pattern. Fixes #1350 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
bug
- test_make_kwargs_regular: verifies make_kwargs passed to regular make - test_make_kwargs_tripartite: verifies make_kwargs passed to make_fetch in the tripartite (generator) pattern (regression test for #1350) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Jan 30, 2026
d-v-b
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
make_kwargsnot being passed tomake_fetchwhen using the tripartite (generator) patternProblem
When using generator-based
makewithmake_fetch,make_compute, andmake_insert, themake_kwargsparameter passed topopulate()was not forwarded tomake_fetch(). This caused aTypeErrorwhen users tried to pass keyword arguments to their tripartite make implementation.Solution
make(self, key)tomake(self, key, **kwargs)**kwargstoself.make_fetch(key, **kwargs)Fixes #1350
🤖 Generated with Claude Code