fix: use hatchling to build package #1358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
dimitri-yatsenko
approved these changes
Jan 30, 2026
Member
dimitri-yatsenko
left a comment
dimitri-yatsenko
left a comment
There was a problem hiding this comment.
Review: Approved ✅
Verified the fix works correctly:
-
Build succeeds:
python -m build --wheelproducesdatajoint-2.1.0a9-py3-none-any.whl -
Subpackages included: The
builtin_codecssubpackage is now correctly packaged:datajoint/builtin_codecs/__init__.py datajoint/builtin_codecs/attach.py datajoint/builtin_codecs/blob.py datajoint/builtin_codecs/filepath.py datajoint/builtin_codecs/hash.py datajoint/builtin_codecs/npy.py datajoint/builtin_codecs/object.py datajoint/builtin_codecs/schema.py -
Import works:
import datajointsucceeds (previously failed withImportError: cannot import name 'builtin_codecs') -
Version test passes:
importlib.metadata.version('datajoint') == datajoint.__version__
Changes look good:
- Switching from setuptools to hatchling is a sensible modernization
- Removing
setuptoolsfrom runtime dependencies is correct - Using
[project.scripts]instead of[project.entry-points."console_scripts"]is the modern standard - The new version test is a useful regression guard
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use hatchling instead of setuptools as the build system. Fixes #1357. I also add a test that ensures that the version of the package internally matches that reported by the built version.