fix: validate system email before invitations#613
Open
tongshiyuan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix member invitations reporting success when system email is disabled.
SMTP test emails can succeed even when
SYSTEM_EMAIL_ENABLEDis false, because the test endpointintentionally allows disabled-but-configured SMTP settings. The invitation flow uses normal system email
delivery, so it skipped sending but still returned a success response.
This change adds a preflight check before creating invitation codes. If SMTP is configured but system
email is disabled, the API now returns a clear 400 error instead of silently skipping delivery.
Checklist