Skip to content

feat: add stop.sh with Docker and local PID cleanup#413

Closed
XiaOldMan wants to merge 1 commit intodataelement:mainfrom
XiaOldMan:main
Closed

feat: add stop.sh with Docker and local PID cleanup#413
XiaOldMan wants to merge 1 commit intodataelement:mainfrom
XiaOldMan:main

Conversation

@XiaOldMan
Copy link
Copy Markdown

@XiaOldMan XiaOldMan commented Apr 15, 2026

  • Support both Docker and local deployment modes
  • Graceful shutdown with SIGTERM, fallback to SIGKILL
  • Cleanup residual processes by port

Summary

Checklist

  • Tested locally
  • No unrelated changes included

- Support both Docker and local deployment modes
- Graceful shutdown with SIGTERM, fallback to SIGKILL
- Cleanup residual processes by port
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee47f512f1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +23 to +26
DIR_NAME=$(basename "$(dirname "$ROOT")")
[ -z "$DIR_NAME" ] && DIR_NAME="custom"
PROJECT_NAME="clawith-${DIR_NAME}"
export COMPOSE_PROJECT_NAME="$PROJECT_NAME"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Target the correct Docker Compose project when stopping

This script forces COMPOSE_PROJECT_NAME to clawith-${parent_dir}, but the documented Docker startup flow uses plain docker compose up -d, which defaults to the repository directory name (typically clawith). In that common path, docker compose down here addresses a different project and leaves the actual Clawith containers running, so users can get a false “stopped” result while services continue consuming resources.

Useful? React with 👍 / 👎.

@XiaOldMan XiaOldMan closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant