feat: add stop.sh with Docker and local PID cleanup#413
feat: add stop.sh with Docker and local PID cleanup#413XiaOldMan wants to merge 1 commit intodataelement:mainfrom
Conversation
- Support both Docker and local deployment modes - Graceful shutdown with SIGTERM, fallback to SIGKILL - Cleanup residual processes by port
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee47f512f1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| DIR_NAME=$(basename "$(dirname "$ROOT")") | ||
| [ -z "$DIR_NAME" ] && DIR_NAME="custom" | ||
| PROJECT_NAME="clawith-${DIR_NAME}" | ||
| export COMPOSE_PROJECT_NAME="$PROJECT_NAME" |
There was a problem hiding this comment.
Target the correct Docker Compose project when stopping
This script forces COMPOSE_PROJECT_NAME to clawith-${parent_dir}, but the documented Docker startup flow uses plain docker compose up -d, which defaults to the repository directory name (typically clawith). In that common path, docker compose down here addresses a different project and leaves the actual Clawith containers running, so users can get a false “stopped” result while services continue consuming resources.
Useful? React with 👍 / 👎.
Summary
Checklist