Split trigger-tests job and route workflow dispatch through emu-access runner#1883
Open
mihaimitrea-db wants to merge 1 commit intomainfrom
Open
Split trigger-tests job and route workflow dispatch through emu-access runner#1883mihaimitrea-db wants to merge 1 commit intomainfrom
mihaimitrea-db wants to merge 1 commit intomainfrom
Conversation
…s runner Fixes automated Integration Tests for PRs on this repo. Splits trigger-tests into create-check (stays on databricks-protected-runner-group, creates the check run on this repo) and trigger-tests (moves to databricks-release-runner-group-emu-access to perform the cross-org dispatch to databricks-eng/eng-dev-ecosystem). Since the databricks org tightened its IP allow list, the protected runner group can no longer call /repos/databricks-eng/.../installation, so create-github-app-token for the workflow-trigger app fails with 403 and no dispatch is sent. The emu-access runner pool's egress IPs are on the allow list. Ports the fix from databricks/databricks-sdk-go#1638. Co-authored-by: Isaac
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
mihaimitrea-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
mihaimitrea-db
had a problem deploying
to
test-trigger-is
GitHub Actions
Error
hectorcast-db
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the PR-triggered Integration Tests check, which has failed on every PR since the
databricksorg tightened its IP allow list (2026-04-17 – 2026-04-20).What changed
.github/workflows/integration-tests.yml— split the oldtrigger-testsjob in two:create-checkdatabricks-protected-runner-groupIntegration Testscheck run on this repo.trigger-testsdatabricks-release-runner-group-emu-accessworkflow_dispatchintodatabricks-eng/eng-dev-ecosystem.The
check_run_idis now passed between jobs vianeeds.create-check.outputs.check_run_id.Why
Before the allow-list change, both steps ran on
databricks-protected-runner-group. After it, that pool's egress IPs can no longer reach thedatabricks-engorg, so:actions/create-github-app-token(owner${{ secrets.ORG_NAME }}=databricks-eng) hits/repos/databricks-eng/.../installation→ HTTP 403.gh workflow run vscode-isolated-pr.ymldispatch never fires.merge_groupauto-approves the check without actually running tests.The
databricks-release-runner-group-emu-accesspool's egress IPs are on thedatabricks-engallow list, so moving just the cross-org dispatch step there restores the flow.create-checkstays on the protected group because creating a check run on this repo doesn't need cross-org access.Where this comes from
Ported from sibling repos that have already shipped the same fix:
Private-side counterpart (already merged): databricks-eng/eng-dev-ecosystem#1254.
How is this tested
This PR's own Integration Tests run is the test. Expected outcome:
create-checksucceeds; check run appears on PR head.trigger-testsruns on the emu-access runner,create-github-app-tokensucceeds (no 403), and avscode-isolated-prworkflow_dispatchevent appears ondatabricks-eng/eng-dev-ecosystem.queued→in_progress→success/failure.NO_CHANGELOG=trueThis pull request and its description were written by Isaac.