AIR CLI Migration: render air get run as styled boxes#5654
Open
riddhibhagwat-db wants to merge 1 commit into
Open
AIR CLI Migration: render air get run as styled boxes#5654riddhibhagwat-db wants to merge 1 commit into
air get run as styled boxes#5654riddhibhagwat-db wants to merge 1 commit into
Conversation
Replace the plain text view of `air get run <id>` with a one-shot, styled terminal renderer built on lipgloss + termenv: - Configuration box: the resolved run config YAML (inline params, downloaded params file, or synthesized), colorized line by line. - Training Progress box: a completed/in-progress bar whose step counts come from MLflow (max metric step over the max_steps param). - Metadata box: Run ID, Status, Submitted, Retries, Max Retries, Duration, Experiment, MLflow Run, User, Accelerators, Environment, with OSC 8 hyperlinks on Run ID and MLflow Run. Boxes share a light-purple border/title, warm Oat neutrals, and a restrained accent palette. Honors --no-color / NO_COLOR / non-TTY via termenv.Ascii; links degrade to the bare label (URLs stay in -o json). Sweep (foreach) runs and JSON output are unchanged. termenv becomes a direct dependency (annotated in go.mod and NOTICE). Co-authored-by: Isaac
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 0275200
20 interesting tests: 13 SKIP, 7 KNOWN
Top 28 slowest tests (at least 2 minutes):
|
air get run as styled boxesair get run as styled boxes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replaces the plain-text view of
air get run <id>with a one-shot, styled terminal renderer built on lipgloss (layout/styling) and termenv (hyperlinks + color-profile detection). It builds the full string and writes it once — no streaming, spinner, or redraw.The view is three boxes:
yaml_parameters, the downloadedyaml_parameters_file_path, or a synthesized fallback), colorized line by line.stepover themax_stepsparam); falls back to a status-driven bar when there's no step data.--no-color/NO_COLOR/ non-TTY viatermenv.Ascii: no escape codes, and links degrade to the bare label (the URLs remain available in-o jsonasdashboard_url/mlflow_url).termenvbecomes a direct dependency (annotated// MITingo.mod, added toNOTICE).Why
Testing
render_test.go/mlflow_test.gocover the box, progress bar, field list, link fallback, config sourcing, and MLflow step parsing.acceptance/experimental/air/get).go build ./...,./task lint-q(0 issues), and the air + acceptance suites pass.Co-authored by Isaac.