acc: run model_serving_endpoints/basic locally#5650
Open
pietern wants to merge 2 commits into
Open
Conversation
Make the model_serving_endpoints/basic acceptance test runnable against the in-process testserver fake. The test only failed locally on output diffs. Two fixes: - Set IsServicePrincipal in test.toml (and flip Local on) so the fake reports the deployer as a service principal, matching the cloud goldens where the auto-added CAN_MANAGE ACL serializes as service_principal_name. - Have the serving-endpoints testserver populate CreationTimestamp / LastUpdatedTimestamp on create (and bump LastUpdatedTimestamp on update) and force-send an empty Description, matching the fields the real backend echoes back. Sibling serving goldens are regenerated to include these fields. Co-authored-by: Isaac
Contributor
Approval status: pending
|
The terraform engine stores access_control as a set whose iteration order depends on the unmasked principal value, so the local fake SP and the real cloud SP produce different ACL orderings in the recorded PUT. Sort the recorded access_control_list via gron.py --sort-arrays (same pattern as permissions/jobs/delete_one) so the terraform request golden matches both local and cloud. Verified passing on aws-prod-ucws for both engines. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: cc92b8f
22 interesting tests: 13 SKIP, 7 KNOWN, 2 flaky
Top 21 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
model_serving_endpoints/basicrunnable locally; the endpoints were already modeled and it only failed on output diffs.Sets
IsServicePrincipal = trueso the CAN_MANAGE ACL serializes asservice_principal_namelike the cloud golden, and populates create/update timestamps + an emptydescriptionon the fake endpoint to match the fields the backend echoes back.Recorded ACLs are sorted via
gron.py --sort-arraysbecause the terraform engine's set ordering depends on the principal value and so differs between the local fake SP and the real cloud SP.Re-baselines sibling serving goldens. Verified passing on aws-prod-ucws for both engines.
This pull request and its description were written by Isaac.