acc: fix testserver workspace export envelope#5649
Open
pietern wants to merge 1 commit into
Open
Conversation
…ort envelope The jobs/check-metadata acceptance test was cloud-only because the in-process testserver returned raw file bytes from GET /api/2.0/workspace/export, whereas the real endpoint returns a JSON envelope whose base64 "content" field the SDK decodes. As a result `databricks workspace export` produced empty output locally and the test's metadata.json greps failed. The export handler now returns a workspace.ExportResponse with base64-encoded content for the SDK path, while still returning raw bytes for the filer's ?direct_download=true reads. This also fixes a latent testserver bug affecting any local single-file workspace export. Co-authored-by: Isaac
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 8e07285
25 interesting tests: 13 SKIP, 7 KNOWN, 5 flaky
Top 20 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /api/2.0/workspace/exportnow returns a base64ExportResponsefor the SDK path (raw bytes still fordirect_download=true), sodatabricks workspace exportworks locally.Lets
jobs/check-metadatarun against the fake.This pull request and its description were written by Isaac.